Skip to content

Conversation

ayanamist
Copy link
Contributor

@ayanamist ayanamist commented May 18, 2021

Make sure set the target branch to develop

What is the purpose of the change

Improve unit test stability. mvn clean package sometimes will fail with strange issues, and retry will solve it. So i try to fix and stabilize these issues.

Brief changelog

I found the main issue is caused by powermock & mockito compatibility which results strange mock problems, so i remove powermock dependency.

Verifying this change

fix 2904

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Bump mockito-core to 3.10.0, remove powermock dependency, suppress useless logging
@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 54.079% when pulling 1350c3f on ayanamist:fix-test into be6eaf8 on apache:develop.

@duhenglucky duhenglucky merged commit 5d21257 into apache:develop May 19, 2021
@duhenglucky duhenglucky changed the title Fix unit test stability [ISSUE #2904]Fix unit test stability May 19, 2021
@ayanamist ayanamist deleted the fix-test branch May 19, 2021 03:40
@vongosling vongosling added this to the 4.8.1 milestone May 19, 2021
@zongtanghu zongtanghu modified the milestones: 4.8.1, 4.9.0 Jun 4, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants