[ISSUE #3148]Support metadata export #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3149 +/- ##
=============================================
+ Coverage 47.82% 48.05% +0.23%
+ Complexity 4551 4348 -203
=============================================
Files 552 514 -38
Lines 36643 35040 -1603
Branches 4846 4669 -177
=============================================
- Hits 17526 16840 -686
+ Misses 16881 16015 -866
+ Partials 2236 2185 -51
Continue to review full report at Codecov.
|
RongtongJin
requested changes
Sep 12, 2021
distribution/bin/export.sh
Outdated
Comment on lines
25
to
41
| download() { | ||
| if [[ -e /tmp/rocketmq/ ]]; then | ||
| rm -rf /tmp/rocketmq/ | ||
| fi | ||
|
|
||
| wget --no-check-certificate -P /tmp/rocketmq/ https://ons-migration.oss-cn-hangzhou.aliyuncs.com/rocketmq-for-export.tar.gz | ||
| if [[ $? -ne 0 ]]; then | ||
| echo -e "[ERROR] Download rocketmq error, please make sure this file exists" | ||
| exit 1 | ||
| else | ||
| echo -e "[INFO] Download rocketmq completed，file path: $(pwd)/rocketmq-for-export.tar.gz" | ||
| fi | ||
|
|
||
| tar -zxvf /tmp/rocketmq/rocketmq-for-export.tar.gz -C /tmp/rocketmq/ > /dev/null 2>&1 | ||
|
|
||
| echo -e "[INFO] Unzip rocketmq-for-export.tar.gz completed" | ||
| } |
There was a problem hiding this comment.
It is not appropriate to download packages from OSS here
There was a problem hiding this comment.
has been deleted about oss
RongtongJin
approved these changes
Sep 12, 2021
caigy
requested changes
Sep 15, 2021
|
|
||
| try { | ||
| String clusterName = commandLine.getOptionValue('c').trim(); | ||
| String filePath = !commandLine.hasOption('f') ? "/tmp/rocketmq/export" : commandLine.getOptionValue('f') |
There was a problem hiding this comment.
Define a constant for "/tmp/rocketmq/export"
Comment on lines
120
to
121
| ConcurrentMap<String, TopicConfig> topicConfigMap = new ConcurrentHashMap<>(); | ||
| ConcurrentMap<String, SubscriptionGroupConfig> subGroupConfigMap = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Will topicConfigMap subGroupConfigMap be used by multiple threads? If not, it would be better just use plain HashMap here.
Comment on lines
83
to
89
| Map<String, Properties> map = new HashMap<>(); | ||
| Properties masterProperties = defaultMQAdminExt.getBrokerConfig(masterAddr); | ||
| map.put("master", needBrokerProprties(masterProperties)); | ||
| masterBrokerSize++; | ||
| slaveBrokerSize += masterAndSlaveMap.get(masterAddr).size(); | ||
|
|
||
| brokerConfigs.put(masterProperties.getProperty("brokerName"), needBrokerProprties(masterProperties)); |
There was a problem hiding this comment.
What is the purpose of map defined in this loop?
| .iterator(); | ||
| while (iterator.hasNext()) { | ||
| String topic = iterator.next().getKey(); | ||
| if (topicList.getTopicList().contains(topic) || !specialTopic && (topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) { |
There was a problem hiding this comment.
!specialTopic && (topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))
这段逻辑应该再加个括号
There was a problem hiding this comment.
这里加不加括号，逻辑都是一样的，但是为了方便理解，我还是加上去了
There was a problem hiding this comment.
嗯嗯，逻辑清晰一点，未来加个条件也不会出bug
dingshuangxi888
approved these changes
Sep 26, 2021
RongtongJin
approved these changes
Oct 13, 2021
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.