[ISSUE #3173]Isolate Broker logs when multiple Broker services are deployed on the same machine. #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are deployed on the same machine
|
|
yuz10
reviewed
Jul 24, 2021
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3174 +/- ##
=============================================
+ Coverage 47.84% 49.15% +1.31%
+ Complexity 4555 3672 -883
=============================================
Files 552 312 -240
Lines 36642 29380 -7262
Branches 4848 4183 -665
=============================================
- Hits 17530 14441 -3089
+ Misses 16883 12972 -3911
+ Partials 2229 1967 -262
Continue to review full report at Codecov.
|
|
IMO, Could it be configured as optional? Otherwise, the sudden change of log directory is very confused for users. |
RongtongJin
reviewed
Sep 12, 2021
|
@RongtongJin @yuz10 can you review this pr again ? |
yuz10
approved these changes
Sep 24, 2021
RongtongJin
reviewed
Sep 27, 2021
| @@ -187,6 +187,13 @@ public static BrokerController createBrokerController(String[] args) { | |||
| JoranConfigurator configurator = new JoranConfigurator(); | |||
| configurator.setContext(lc); | |||
| lc.reset(); | |||
| System.setProperty("brokerLogDir", ""); | |||
There was a problem hiding this comment.
If it is set to "" here, will it be in the original directory by default?
There was a problem hiding this comment.
yes, if brokerLogDir is "", the logPath in logback_broker.xml is default.
RongtongJin
approved these changes
Jan 6, 2022
RongtongJin
reviewed
Jan 6, 2022
| @@ -187,6 +187,8 @@ | |||
|
|
|||
| private boolean autoDeleteUnusedStats = false; | |||
|
|
|||
| private boolean isolateLogEnable = false; | |||
There was a problem hiding this comment.
It would be better to add some comments to explain the meaning of this parameter
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
[ISSUE apache#3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
[ISSUE apache#3173]Isolate Broker logs when multiple Broker services are deployed on the same machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
#3173
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.