Skip to content

Conversation

gorden5566
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

  1. Replace the class 'StringBuffer' by 'StringBuilder'
  2. Add missed '@OverRide' annotation
  3. Add braces to 'if' statement
  4. Add test for UtilAll#list2String

#3203

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 54.201% when pulling 366ee98 on gorden5566:optimize-string-concate into 9e8fea9 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3204 (366ee98) into develop (9e8fea9) will increase coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3204      +/-   ##
=============================================
+ Coverage      48.45%   48.46%   +0.01%     
- Complexity      3185     3188       +3     
=============================================
  Files            418      418              
  Lines          26318    26318              
  Branches        3487     3487              
=============================================
+ Hits           12752    12755       +3     
+ Misses         11921    11914       -7     
- Partials        1645     1649       +4     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/common/message/Message.java 54.21% <0.00%> (ø)
...apache/rocketmq/common/protocol/NamespaceUtil.java 54.83% <0.00%> (ø)
...he/rocketmq/filter/expression/UnaryExpression.java 21.05% <0.00%> (ø)
...g/apache/rocketmq/filter/parser/TokenMgrError.java 0.00% <0.00%> (ø)
...pache/rocketmq/remoting/common/RemotingHelper.java 13.41% <0.00%> (ø)
...pache/rocketmq/store/stats/BrokerStatsManager.java 75.89% <50.00%> (ø)
.../apache/rocketmq/filter/parser/ParseException.java 49.25% <66.66%> (ø)
...cketmq/acl/plain/RemoteAddressStrategyFactory.java 89.76% <100.00%> (ø)
.../main/java/org/apache/rocketmq/common/UtilAll.java 40.25% <100.00%> (+2.59%) ⬆️
...ache/rocketmq/store/AllocateMappedFileService.java 39.02% <0.00%> (-2.44%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8fea9...366ee98. Read the comment docs.

@odbozhou odbozhou merged commit 44bdeed into apache:develop Aug 4, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants