Skip to content

Conversation

Git-Yang
Copy link
Member

What is the purpose of the change

#2667

Brief changelog

  • Ensure that the commitlog and consumequeue paths exist when the service starts

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Git-Yang Git-Yang changed the title [ISSUE #2667] Repair 'Error when measuring disk space usage' [ISSUE #2667] Repair 'file doesn't exist on this path' Aug 20, 2021
@coveralls
Copy link

coveralls commented Aug 20, 2021

Coverage Status

Coverage increased (+0.03%) to 54.509% when pulling a6a4eb4 on Git-Yang:log-error into 4dbdbf0 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #3278 (45741bc) into develop (9a5ec90) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3278      +/-   ##
=============================================
+ Coverage      47.89%   47.94%   +0.05%     
+ Complexity      4558     4552       -6     
=============================================
  Files            552      552              
  Lines          36637    36522     -115     
  Branches        4845     4817      -28     
=============================================
- Hits           17548    17512      -36     
+ Misses         16859    16790      -69     
+ Partials        2230     2220      -10     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/DefaultMessageStore.java 55.58% <75.00%> (+0.17%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...rocketmq/broker/pagecache/ManyMessageTransfer.java 36.36% <0.00%> (-9.80%) ⬇️
.../rocketmq/broker/pagecache/OneMessageTransfer.java 24.00% <0.00%> (-9.34%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.09%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-4.48%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 75.55% <0.00%> (-4.45%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5ec90...45741bc. Read the comment docs.

@duhenglucky
Copy link
Contributor

@Git-Yang conflicts appeared after other PRS merged :)

@Git-Yang
Copy link
Member Author

@Git-Yang conflicts appeared after other PRS merged :)

Conflict fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLeger模式下broker.log 一直抛出 Error when measuring disk space usage, file doesn't exist on this path: /root/store/commitlog
6 participants