Skip to content

Conversation

zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#3284

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Aug 24, 2021

Coverage Status

Coverage increased (+0.01%) to 54.232% when pulling 491c432 on zhangjidi2016:optimize_benchmark into 9e66da4 on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #3285 (491c432) into develop (9e66da4) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3285      +/-   ##
=============================================
- Coverage      48.01%   47.95%   -0.06%     
+ Complexity      4561     4556       -5     
=============================================
  Files            552      552              
  Lines          36536    36536              
  Branches        4822     4822              
=============================================
- Hits           17541    17522      -19     
- Misses         16772    16794      +22     
+ Partials        2223     2220       -3     
Impacted Files Coverage Δ
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 49.55% <0.00%> (-1.49%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) ⬇️
...ocketmq/store/schedule/ScheduleMessageService.java 74.24% <0.00%> (-1.02%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 29.50% <0.00%> (-0.66%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.03% <0.00%> (-0.52%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 39.84% <0.00%> (-0.40%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.11% <0.00%> (-0.37%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.60% <0.00%> (-0.32%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e66da4...491c432. Read the comment docs.

@zongtanghu zongtanghu merged commit 7c7e9ac into apache:develop Aug 26, 2021
@zhangjidi2016 zhangjidi2016 deleted the optimize_benchmark branch April 14, 2022 13:30
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* [ISSUE apache#3284]Optimizing benchmark code

* Reduce calls to the longValue method in the loop

Co-authored-by: zhangjidi <[email protected]>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* [ISSUE apache#3284]Optimizing benchmark code

* Reduce calls to the longValue method in the loop

Co-authored-by: zhangjidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants