Skip to content

[ISSUE 3585] [Part C] cache the result of parseChannelRemoteAddr() #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[ISSUE 3585] [Part C] cache the result of parseChannelRemoteAddr() #3589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
package org.apache.rocketmq.remoting.common;

import io.netty.channel.Channel;
import io.netty.util.Attribute;
import io.netty.util.AttributeKey;

import java.io.IOException;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
Expand All @@ -34,6 +37,7 @@ public class RemotingHelper {
public static final String DEFAULT_CHARSET = "UTF-8";

private static final InternalLogger log = InternalLoggerFactory.getLogger(ROCKETMQ_REMOTING);
private static final AttributeKey<String> REMOTE_ADDR_KEY = AttributeKey.valueOf("RemoteAddr");

public static String exceptionSimpleDesc(final Throwable e) {
StringBuilder sb = new StringBuilder();
Expand Down Expand Up @@ -155,6 +159,20 @@ public static String parseChannelRemoteAddr(final Channel channel) {
if (null == channel) {
return "";
}
Attribute<String> att = channel.attr(REMOTE_ADDR_KEY);
if (att == null) {
// mocked in unit test
return parseChannelRemoteAddr0(channel);
}
String addr = att.get();
if (addr == null) {
addr = parseChannelRemoteAddr0(channel);
att.set(addr);
}
return addr;
}

private static String parseChannelRemoteAddr0(final Channel channel) {
SocketAddress remote = channel.remoteAddress();
final String addr = remote != null ? remote.toString() : "";

Expand Down