Skip to content

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Polish travis.yml to run integration tests
#3654

Brief changelog

1.Make travis to run integration tests
2.Fix running testSynSendNullMessage failed

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Dec 15, 2021

Coverage Status

Coverage increased (+0.1%) to 56.288% when pulling 07ee961 on RongtongJin:polish_travis into ecb061a on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3655 (07ee961) into develop (ecb061a) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3655      +/-   ##
=============================================
+ Coverage      49.69%   49.79%   +0.10%     
- Complexity      4725     4740      +15     
=============================================
  Files            555      555              
  Lines          36798    36798              
  Branches        4853     4853              
=============================================
+ Hits           18286    18324      +38     
+ Misses         16214    16173      -41     
- Partials        2298     2301       +3     
Impacted Files Coverage Δ
...tmq/logappender/log4j2/RocketmqLog4j2Appender.java 35.00% <0.00%> (-10.00%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 74.51% <0.00%> (+0.11%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.86% <0.00%> (+0.46%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.51% <0.00%> (+0.51%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (+0.79%) ⬆️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 42.57% <0.00%> (+1.17%) ⬆️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.00% <0.00%> (+1.47%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 79.70% <0.00%> (+1.48%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb061a...07ee961. Read the comment docs.

@duhenglucky duhenglucky linked an issue Dec 16, 2021 that may be closed by this pull request
@@ -45,9 +45,9 @@ before_script:
script:
- mvn verify -DskipTests
- travis_retry mvn -B clean apache-rat:check
- travis_retry mvn -B package jacoco:report coveralls:report
- travis_retry mvn -B install jacoco:report coveralls:report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITTest is designed to execute after we run successfully. We have two tasks when building, after success is a heavy operation. If we remove it, we must opt for the core ITTest case. Meanwhile, The queuing problem is very serious and will be exacerbated if you mix long-running tasks in a light task. Our CI/CD system design has been carefully considered. When optimizing the CI/CD system, we should consider all aspects.

@duhenglucky duhenglucky merged commit 8cb1468 into apache:develop Dec 17, 2021
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
…e#3655)

* 1.Make travis to run integration tests
2.Fix running testSynSendNullMessage failed

* Remove run 'mvn clean install -Pit-test' after success

* Change package to install when running UT
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…e#3655)

* 1.Make travis to run integration tests
2.Fix running testSynSendNullMessage failed

* Remove run 'mvn clean install -Pit-test' after success

* Change package to install when running UT
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
…e#3655)

* 1.Make travis to run integration tests
2.Fix running testSynSendNullMessage failed

* Remove run 'mvn clean install -Pit-test' after success

* Change package to install when running UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish travis.yml to run integration tests
7 participants