-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #3684] change client jdk version to 1.6 #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3683 +/- ##
=============================================
- Coverage 47.37% 47.23% -0.15%
+ Complexity 5044 5030 -14
=============================================
Files 627 627
Lines 41348 41371 +23
Branches 5372 5374 +2
=============================================
- Hits 19588 19540 -48
- Misses 19332 19406 +74
+ Partials 2428 2425 -3
Continue to review full report at Codecov.
|
What is this? For traditional cloud customers, you could create a release branch. Or say, you cancel JDK8 some special semantics, release two packages, one of them is backporting 1.6. |
If there is no other significant reason, it is better to keep 1.6 for the client, to be compatible with traditional enterprise users. |
You can calculate the percentage of traditional enterprises in your customers? If you could learn more life-cycle governance about production, you could not insist on this solution. I have given you another backport way to support and educate enterprise customers. I think we have many of these customers in ours. Pls remember, Open source doesn't kidnap by our business. You can support innovation and smooth upgrades in a more collaborative way. |
[ISSUE apache#3684] change client jdk version to 1.6
[ISSUE apache#3684] change client jdk version to 1.6
Make sure set the target branch to
develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.