Skip to content

Conversation

duhenglucky
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky linked an issue Dec 31, 2021 that may be closed by this pull request
@duhenglucky duhenglucky changed the title chore(client) change client jdk version to 1.6 [ISSUE #3684] change client jdk version to 1.6 Dec 31, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 53.207% when pulling 1be3cc3 on duhenglucky:develop_jdk into 9f9b109 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3683 (1be3cc3) into develop (9f9b109) will decrease coverage by 0.14%.
The diff coverage is 19.44%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3683      +/-   ##
=============================================
- Coverage      47.37%   47.23%   -0.15%     
+ Complexity      5044     5030      -14     
=============================================
  Files            627      627              
  Lines          41348    41371      +23     
  Branches        5372     5374       +2     
=============================================
- Hits           19588    19540      -48     
- Misses         19332    19406      +74     
+ Partials        2428     2425       -3     
Impacted Files Coverage Δ
...rocketmq/client/impl/factory/MQClientInstance.java 52.96% <0.00%> (-0.33%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.98% <0.00%> (-0.97%) ⬇️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 12.84% <50.00%> (-0.03%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.99% <100.00%> (-0.52%) ⬇️
.../rocketmq/client/producer/RequestFutureHolder.java 81.39% <100.00%> (ø)
.../trace/hook/ConsumeMessageOpenTracingHookImpl.java 74.35% <100.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...tmq/logappender/log4j2/RocketmqLog4j2Appender.java 35.00% <0.00%> (-10.00%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9b109...1be3cc3. Read the comment docs.

@vongosling
Copy link
Member

What is this? For traditional cloud customers, you could create a release branch. Or say, you cancel JDK8 some special semantics, release two packages, one of them is backporting 1.6.

@dongeforever
Copy link
Member

If there is no other significant reason, it is better to keep 1.6 for the client, to be compatible with traditional enterprise users.

@vongosling
Copy link
Member

You can calculate the percentage of traditional enterprises in your customers? If you could learn more life-cycle governance about production, you could not insist on this solution. I have given you another backport way to support and educate enterprise customers. I think we have many of these customers in ours. Pls remember, Open source doesn't kidnap by our business. You can support innovation and smooth upgrades in a more collaborative way.

@duhenglucky duhenglucky added this to the 4.9.3 milestone Jan 12, 2022
@francisoliverlee francisoliverlee merged commit e1056ef into apache:develop Jan 17, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The client provides support for JDK 1.6