Skip to content

Conversation

Conlin569
Copy link
Contributor

Make sure set the target branch to develop

Maybe dever forgot to delete it

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 53.22% when pulling 85d7c4e on Colin678:master into 6ebb4e4 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3695 (85d7c4e) into develop (3ae2517) will increase coverage by 1.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3695      +/-   ##
=============================================
+ Coverage      45.98%   47.25%   +1.27%     
- Complexity      4320     5026     +706     
=============================================
  Files            547      627      +80     
  Lines          36236    41348    +5112     
  Branches        4808     5373     +565     
=============================================
+ Hits           16663    19539    +2876     
- Misses         17490    19386    +1896     
- Partials        2083     2423     +340     
Impacted Files Coverage Δ
...g/apache/rocketmq/common/sysflag/TopicSysFlag.java 0.00% <ø> (ø)
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) ⬇️
...rocketmq/broker/pagecache/ManyMessageTransfer.java 36.36% <0.00%> (-9.80%) ⬇️
.../rocketmq/broker/pagecache/OneMessageTransfer.java 24.00% <0.00%> (-9.34%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-8.93%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-8.89%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 41.40% <0.00%> (-8.80%) ⬇️
...va/org/apache/rocketmq/store/GetMessageResult.java 71.73% <0.00%> (-6.84%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-5.71%) ⬇️
...ain/java/org/apache/rocketmq/test/util/MQWait.java 43.24% <0.00%> (-5.41%) ⬇️
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae2517...85d7c4e. Read the comment docs.

@Git-Yang
Copy link
Member

Git-Yang commented Jan 5, 2022

Can you create an issue for this PR?

@duhenglucky duhenglucky added this to the 4.9.3 milestone Jan 21, 2022
@duhenglucky duhenglucky merged commit b46496d into apache:develop Jan 21, 2022
@francisoliverlee francisoliverlee changed the title Remove useless code [ISSUE #XXXX] Remove useless code Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
* [Simple packaging method]packaging method

* [Remove useless code]Maybe dever forgot to delete it

* [Remove useless notes]Wrong commit
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* [Simple packaging method]packaging method

* [Remove useless code]Maybe dever forgot to delete it

* [Remove useless notes]Wrong commit
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* [Simple packaging method]packaging method

* [Remove useless code]Maybe dever forgot to delete it

* [Remove useless notes]Wrong commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants