Skip to content

Conversation

kealdishx
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#3738

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kealdishx kealdishx changed the title [ISSUE #3738]Remove useless callee of String.valueOf [ISSUE #3738]Remove redundant callee of String.valueOf Jan 9, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 53.145% when pulling f113466 on kealdishx:f_remove_useless_callee into 1ef1af6 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3739 (f113466) into develop (1ef1af6) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3739      +/-   ##
=============================================
- Coverage      47.26%   47.18%   -0.08%     
+ Complexity      5042     5023      -19     
=============================================
  Files            628      628              
  Lines          41406    41406              
  Branches        5379     5379              
=============================================
- Hits           19569    19538      -31     
- Misses         19413    19443      +30     
- Partials        2424     2425       +1     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/store/StoreStatsService.java 29.96% <0.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 39.47% <0.00%> (-2.29%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 51.30% <0.00%> (-2.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-1.50%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 41.40% <0.00%> (-1.18%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef1af6...f113466. Read the comment docs.

@yuz10 yuz10 linked an issue Jan 10, 2022 that may be closed by this pull request
@yuz10 yuz10 merged commit acac49f into apache:develop Jan 10, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant callee of String.valueOf
4 participants