Skip to content

Conversation

MatrixHB
Copy link
Contributor

#3581 this PR solves the nonstandard spelling problem of Issue #3579

but it also modified the method declared public, which may lead to incompatible problem for the client. It is better to rollback the change.

@MatrixHB MatrixHB changed the title rollback spelling fix to avoid incompatile [Issue #3579] rollback spelling fix to avoid incompatible problem Jan 12, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 53.203% when pulling 3b5b4fb on MatrixHB:huitong_fix_mqClientFactory into 0b612ff on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3749 (3b5b4fb) into develop (9f9b109) will decrease coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3749      +/-   ##
=============================================
- Coverage      47.37%   47.24%   -0.13%     
+ Complexity      5044     5032      -12     
=============================================
  Files            627      628       +1     
  Lines          41348    41406      +58     
  Branches        5372     5379       +7     
=============================================
- Hits           19588    19563      -25     
- Misses         19332    19420      +88     
+ Partials        2428     2423       -5     
Impacted Files Coverage Δ
...nt/impl/consumer/ConsumeMessageOrderlyService.java 44.40% <0.00%> (ø)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 41.40% <ø> (-0.79%) ⬇️
...client/trace/hook/EndTransactionTraceHookImpl.java 13.33% <0.00%> (ø)
...cketmq/client/impl/consumer/RebalancePushImpl.java 35.51% <50.00%> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.94% <75.00%> (ø)
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.51% <100.00%> (ø)
...lient/impl/consumer/DefaultMQPullConsumerImpl.java 29.76% <100.00%> (ø)
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 41.75% <100.00%> (ø)
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 79.70% <100.00%> (+1.48%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9b109...3b5b4fb. Read the comment docs.

@duhenglucky duhenglucky merged commit 5233f12 into apache:develop Jan 13, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants