Skip to content

Conversation

ShannonDing
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

fix build error in RIP-28 at getmQClientFactory

Brief changelog

change to getmQclientFactory

Verifying this change

ci pass

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing
Copy link
Member Author

fix ci issue

@codecov-commenter
Copy link

Codecov Report

Merging #3754 (a45f643) into develop (8d28d3f) will decrease coverage by 0.27%.
The diff coverage is 34.07%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3754      +/-   ##
=============================================
- Coverage      47.26%   46.98%   -0.28%     
+ Complexity      5038     4854     -184     
=============================================
  Files            628      636       +8     
  Lines          41406    42244     +838     
  Branches        5379     5521     +142     
=============================================
+ Hits           19572    19850     +278     
- Misses         19408    19912     +504     
- Partials        2426     2482      +56     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 46.54% <0.00%> (-0.89%) ⬇️
.../broker/longpolling/LmqPullRequestHoldService.java 0.00% <0.00%> (ø)
...e/rocketmq/broker/longpolling/ManyPullRequest.java 0.00% <0.00%> (ø)
...etmq/broker/plugin/AbstractPluginMessageStore.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 34.38% <0.00%> (-0.19%) ⬇️
...ocketmq/broker/processor/SendMessageProcessor.java 39.59% <0.00%> (-0.30%) ⬇️
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...he/rocketmq/store/stats/LmqBrokerStatsManager.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/test/util/StatUtil.java 16.19% <16.19%> (ø)
...cketmq/broker/offset/LmqConsumerOffsetManager.java 44.44% <44.44%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b63ee...a45f643. Read the comment docs.

@duhenglucky duhenglucky merged commit bfaef39 into apache:develop Jan 14, 2022
@ShannonDing ShannonDing changed the title fix build error in RIP-28 at getmQClientFactory fix CI error in RIP-28 at getmQClientFactory Jan 14, 2022
@ShannonDing ShannonDing changed the title fix CI error in RIP-28 at getmQClientFactory [ISSUE #3666]fix CI error in RIP-28 at getmQClientFactory Jan 14, 2022
@ShannonDing ShannonDing added this to the 4.9.3 milestone Jan 17, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
* fix build error in RIP-28 at getmQclientFactory

* fix build error in RIP-28 at getmQclientFactory
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* fix build error in RIP-28 at getmQclientFactory

* fix build error in RIP-28 at getmQclientFactory
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* fix build error in RIP-28 at getmQclientFactory

* fix build error in RIP-28 at getmQclientFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants