Skip to content

Conversation

areyouok
Copy link
Contributor

@areyouok areyouok commented Feb 8, 2022

For more informance see #3825

…value.

This commit may greatly increase thoughtput when network lantency is big or message size is big, especially for consumer.

In one broker (M/S sync master async flush), one producer send test.

250 byte body: 0.93x old version
4000 byte body: 3.85x of old version
16000 byte body: 6.07x of old version
100000 byte body: 7.93x of old version

The old version is 4.9.3-SNAPSHOT in this test. In this test the network latency from producer to broker is 1.61ms.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 51.257% when pulling 7f7acf4 on areyouok:auto_buffer into d5c8800 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3826 (7f7acf4) into develop (d5c8800) will decrease coverage by 0.02%.
The diff coverage is 35.29%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3826      +/-   ##
=============================================
- Coverage      47.20%   47.17%   -0.03%     
+ Complexity      4887     4886       -1     
=============================================
  Files            636      636              
  Lines          42468    42482      +14     
  Branches        5553     5561       +8     
=============================================
- Hits           20046    20041       -5     
- Misses         19915    19926      +11     
- Partials        2507     2515       +8     
Impacted Files Coverage Δ
...java/org/apache/rocketmq/broker/BrokerStartup.java 5.63% <ø> (+0.15%) ⬆️
.../apache/rocketmq/remoting/common/RemotingUtil.java 12.26% <0.00%> (-0.24%) ⬇️
...ava/org/apache/rocketmq/store/ha/HAConnection.java 66.51% <0.00%> (-1.51%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 46.61% <36.36%> (-0.95%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 59.24% <36.36%> (-2.04%) ⬇️
...che/rocketmq/remoting/netty/NettySystemConfig.java 96.00% <100.00%> (ø)
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...che/rocketmq/remoting/netty/NettyClientConfig.java 48.21% <0.00%> (-1.79%) ⬇️
...che/rocketmq/remoting/netty/NettyServerConfig.java 48.27% <0.00%> (-1.73%) ⬇️
...rg/apache/rocketmq/remoting/netty/NettyLogger.java 14.96% <0.00%> (-1.37%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c8800...7f7acf4. Read the comment docs.

@areyouok areyouok merged commit 8fa9ca5 into apache:develop Feb 10, 2022
@francisoliverlee francisoliverlee changed the title [ISSUE 3825] Use default SO_SNDBUF/SO_RCVBUF/WRITE_BUFFER_WATER_MARK value [ISSUE #3825] Use default SO_SNDBUF/SO_RCVBUF/WRITE_BUFFER_WATER_MARK value Feb 21, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
…value. (apache#3826)

This commit may greatly increase thoughtput when network lantency is big or message size is big, especially for consumer.

In one broker (M/S sync master async flush), one producer send test.

250 byte body: 0.93x old version
4000 byte body: 3.85x of old version
16000 byte body: 6.07x of old version
100000 byte body: 7.93x of old version

The old version is 4.9.3-SNAPSHOT in this test. In this test the network latency from producer to broker is 1.61ms.
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…value. (apache#3826)

This commit may greatly increase thoughtput when network lantency is big or message size is big, especially for consumer.

In one broker (M/S sync master async flush), one producer send test.

250 byte body: 0.93x old version
4000 byte body: 3.85x of old version
16000 byte body: 6.07x of old version
100000 byte body: 7.93x of old version

The old version is 4.9.3-SNAPSHOT in this test. In this test the network latency from producer to broker is 1.61ms.
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
…value. (apache#3826)

This commit may greatly increase thoughtput when network lantency is big or message size is big, especially for consumer.

In one broker (M/S sync master async flush), one producer send test.

250 byte body: 0.93x old version
4000 byte body: 3.85x of old version
16000 byte body: 6.07x of old version
100000 byte body: 7.93x of old version

The old version is 4.9.3-SNAPSHOT in this test. In this test the network latency from producer to broker is 1.61ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The TCP SO_SNDBUF/SO_RCVBUF is fixed and too small, decrease throughput greatly
8 participants