Skip to content

Conversation

caomao95
Copy link
Contributor

@caomao95 caomao95 commented Feb 9, 2022

delete redundant text

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

vongosling and others added 3 commits December 10, 2021 17:30
Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever
delete redundant text
@XiaoyiPeng
Copy link
Contributor

Please make sure set the target branch to develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 54.417% when pulling 49a7de1 on caomao95:patch-3 into 1b420ce on apache:master.

@duhenglucky duhenglucky changed the base branch from master to develop February 9, 2022 11:08
@duhenglucky duhenglucky merged commit ca92d36 into apache:develop Feb 9, 2022
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* Update design.md

delete redundant text

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* Update design.md

delete redundant text

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* Update design.md

delete redundant text

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants