Skip to content

Conversation

zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 51.326% when pulling 8f995f6 on zhangjidi2016:add_ut into 4992f4e on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3839 (8f995f6) into develop (810b757) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3839      +/-   ##
=============================================
- Coverage      47.25%   47.23%   -0.02%     
- Complexity      4892     4899       +7     
=============================================
  Files            636      636              
  Lines          42468    42481      +13     
  Branches        5553     5561       +8     
=============================================
- Hits           20068    20066       -2     
+ Misses         19900    19896       -4     
- Partials        2500     2519      +19     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 44.77% <0.00%> (-7.47%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 59.24% <0.00%> (-2.04%) ⬇️
...che/rocketmq/remoting/netty/NettyClientConfig.java 48.21% <0.00%> (-1.79%) ⬇️
...che/rocketmq/remoting/netty/NettyServerConfig.java 48.27% <0.00%> (-1.73%) ⬇️
...ava/org/apache/rocketmq/store/ha/HAConnection.java 66.51% <0.00%> (-1.51%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.49%) ⬇️
...ketmq/common/protocol/body/RegisterBrokerBody.java 83.69% <0.00%> (-1.09%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 46.61% <0.00%> (-0.95%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.28% <0.00%> (-0.67%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810b757...8f995f6. Read the comment docs.

@duhenglucky duhenglucky added this to the 4.9.3 milestone Feb 11, 2022
@duhenglucky duhenglucky merged commit 8b78f61 into apache:develop Feb 11, 2022
@zhangjidi2016 zhangjidi2016 deleted the add_ut branch February 11, 2022 04:11
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants