Skip to content

Conversation

MundaneImmortal
Copy link
Contributor

Make sure set the target branch to develop

Description
The test org.apache.rocketmq.common.filter.FilterAPITest.testBuildTagSome may fail
since getTagsSet() returns a HashSet that has undetermined iteration order. One can check for that using the NonDex.

Reproduce the failure

mvn install -pl common -am -DskipTests
mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl common -Dtest=org.apache.rocketmq.common.filter.FilterAPITest#testBuildTagSome

Solution
Use containsExactlyInAnyOrder() instead of containsExactly() for the failing AssertJ assertion.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #3959 (517f0c9) into develop (446b76b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3959      +/-   ##
=============================================
+ Coverage      47.61%   47.63%   +0.02%     
- Complexity      4958     4962       +4     
=============================================
  Files            633      633              
  Lines          42577    42577              
  Branches        5589     5589              
=============================================
+ Hits           20273    20283      +10     
+ Misses         19796    19781      -15     
- Partials        2508     2513       +5     
Impacted Files Coverage Δ
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-1.50%) ⬇️
...ketmq/common/protocol/body/RegisterBrokerBody.java 83.69% <0.00%> (-1.09%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (-0.32%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.59% <0.00%> (-0.19%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 79.70% <0.00%> (ø)
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 44.92% <0.00%> (+0.39%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.31% <0.00%> (+0.51%) ⬆️
...etmq/client/latency/LatencyFaultToleranceImpl.java 51.28% <0.00%> (+1.28%) ⬆️
...ketmq/common/protocol/body/ConsumerConnection.java 100.00% <0.00%> (+4.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446b76b...517f0c9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.716% when pulling 517f0c9 on MundaneImmortal:fix-flaky into c43620f on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 51.716% when pulling 517f0c9 on MundaneImmortal:fix-flaky into c43620f on apache:develop.

@duhenglucky duhenglucky merged commit 895bd95 into apache:develop Mar 14, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone Mar 14, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants