Skip to content

Conversation

XiaoyiPeng
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

For #3985

Brief changelog

Remove shuffle operation before sorting the list of 'FaultItem'.

Verifying this change

XXXX

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #3986 (9a1fbf4) into develop (895bd95) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3986      +/-   ##
=============================================
+ Coverage      47.69%   47.71%   +0.02%     
- Complexity      4969     4974       +5     
=============================================
  Files            633      633              
  Lines          42579    42578       -1     
  Branches        5589     5589              
=============================================
+ Hits           20306    20315       +9     
+ Misses         19765    19758       -7     
+ Partials        2508     2505       -3     
Impacted Files Coverage Δ
...etmq/client/latency/LatencyFaultToleranceImpl.java 49.35% <ø> (-0.65%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 75.08% <0.00%> (-1.02%) ⬇️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.76% <0.00%> (+0.35%) ⬆️
...ava/org/apache/rocketmq/store/ha/HAConnection.java 66.96% <0.00%> (+0.44%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.18% <0.00%> (+1.48%) ⬆️
...a/org/apache/rocketmq/store/StoreStatsService.java 38.09% <0.00%> (+1.68%) ⬆️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 61.29% <0.00%> (+2.15%) ⬆️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 62.39% <0.00%> (+2.56%) ⬆️
...ketmq/common/protocol/body/ConsumerConnection.java 100.00% <0.00%> (+4.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895bd95...9a1fbf4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 51.761% when pulling 9a1fbf4 on XiaoyiPeng:remove_shuffle_operation into 895bd95 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 51.761% when pulling 9a1fbf4 on XiaoyiPeng:remove_shuffle_operation into 895bd95 on apache:develop.

@yuz10 yuz10 added this to the 4.9.4 milestone Mar 14, 2022
@yuz10 yuz10 linked an issue Mar 14, 2022 that may be closed by this pull request
@yuz10 yuz10 merged commit 03c5a3d into apache:develop Mar 14, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is unnecessary to shuffle a list before sorting it.
4 participants