Skip to content

Conversation

li-xiao-shuang
Copy link
Member

@li-xiao-shuang li-xiao-shuang commented Mar 23, 2022

fix : #4053

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #4027 (116a1b9) into develop (0870a83) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4027      +/-   ##
=============================================
+ Coverage      47.91%   47.95%   +0.03%     
- Complexity      5000     5010      +10     
=============================================
  Files            633      633              
  Lines          42528    42524       -4     
  Branches        5573     5573              
=============================================
+ Hits           20376    20391      +15     
+ Misses         19658    19638      -20     
- Partials        2494     2495       +1     
Impacted Files Coverage Δ
...org/apache/rocketmq/namesrv/NamesrvController.java 66.12% <100.00%> (+10.06%) ⬆️
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 60.20% <100.00%> (ø)
...org/apache/rocketmq/common/stats/StatsItemSet.java 46.26% <0.00%> (-5.98%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.79% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.40% <0.00%> (-0.36%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.34% <0.00%> (-0.25%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 37.53% <0.00%> (+0.56%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0870a83...116a1b9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 51.982% when pulling 116a1b9 on li-xiao-shuang:feature_code_optimization into 0870a83 on apache:develop.

Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin
Copy link
Contributor

@li-xiao-shuang Is there an associated issue?

@li-xiao-shuang
Copy link
Member Author

@li-xiao-shuang Is there an associated issue?

There is no corresponding issue

@Git-Yang
Copy link
Member

@li-xiao-shuang Is there an associated issue?

There is no corresponding issue

Can you create an ISSUE for this PR?

@li-xiao-shuang li-xiao-shuang changed the title [Minor] NamesrvController code optimization [ISSUE #4053] NamesrvController code optimization Mar 29, 2022
@li-xiao-shuang
Copy link
Member Author

@li-xiao-shuang Is there an associated issue?

There is no corresponding issue

Can you create an ISSUE for this PR?

done

@RongtongJin RongtongJin merged commit 9fff8ae into apache:develop Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NamesrvController code optimization

8 participants