Skip to content

Conversation

HScarb
Copy link
Contributor

@HScarb HScarb commented Mar 24, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix case of dirty data in deliverPendingTable

Brief changelog

Initialize deliverPendingTable, When the ScheduleService is started

Verifying this change

Before
Snipaste_2022-03-24_21-31-24

After
Snipaste_2022-03-24_21-32-19

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #4032 (49d79e8) into develop (1a72ffd) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4032      +/-   ##
=============================================
- Coverage      47.91%   47.87%   -0.05%     
+ Complexity      4999     4995       -4     
=============================================
  Files            633      633              
  Lines          42528    42528              
  Branches        5573     5573              
=============================================
- Hits           20379    20359      -20     
- Misses         19654    19669      +15     
- Partials        2495     2500       +5     
Impacted Files Coverage Δ
...ocketmq/store/schedule/ScheduleMessageService.java 67.00% <100.00%> (+0.25%) ⬆️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.66% <0.00%> (-0.67%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.97% <0.00%> (-0.57%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (-0.32%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 75.70% <0.00%> (+0.51%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a72ffd...49d79e8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 51.914% when pulling 49d79e8 on HScarb:issue_4004 into 1a72ffd on apache:develop.

Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Git-Yang Git-Yang merged commit 02228d8 into apache:develop Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants