Skip to content

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Mar 30, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix #4065

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #4066 (9cd7a16) into 5.0.0-beta (d99a51c) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@               Coverage Diff                @@
##             5.0.0-beta    #4066      +/-   ##
================================================
+ Coverage         43.14%   43.16%   +0.02%     
+ Complexity         6028     6025       -3     
================================================
  Files               795      795              
  Lines             56823    56825       +2     
  Branches           7780     7780              
================================================
+ Hits              24515    24530      +15     
+ Misses            29114    29104      -10     
+ Partials           3194     3191       -3     
Impacted Files Coverage Δ
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.68% <0.00%> (-0.23%) ⬇️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 24.48% <100.00%> (+0.06%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 39.10% <0.00%> (-0.54%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 49.17% <0.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 52.35% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99a51c...9cd7a16. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 47.203% when pulling 9cd7a16 on cserwen:broker_name_fix into d99a51c on apache:5.0.0-beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 47.203% when pulling 9cd7a16 on cserwen:broker_name_fix into d99a51c on apache:5.0.0-beta.

@duhenglucky duhenglucky merged commit 52482d4 into apache:5.0.0-beta Mar 30, 2022
@duhenglucky duhenglucky added this to the 5.0.0-beta milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants