Skip to content

Conversation

dugenkui03
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#4103

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

[ISSUE #4103] Simplify string-list-join in `Message`
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #4104 (d652cd4) into develop (fd554ab) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4104      +/-   ##
=============================================
- Coverage      47.91%   47.88%   -0.03%     
+ Complexity      5001     4998       -3     
=============================================
  Files            634      634              
  Lines          42529    42525       -4     
  Branches        5573     5572       -1     
=============================================
- Hits           20377    20363      -14     
- Misses         19651    19659       +8     
- Partials        2501     2503       +2     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/common/message/Message.java 56.96% <0.00%> (+2.74%) ⬆️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 41.05% <0.00%> (-2.99%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.64% <0.00%> (-0.71%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.41% <0.00%> (-0.57%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.79% <0.00%> (-0.52%) ⬇️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 57.92% <0.00%> (-0.50%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd554ab...d652cd4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.8% when pulling d652cd4 on dugenkui03:patch-8 into fd554ab on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.8% when pulling d652cd4 on dugenkui03:patch-8 into fd554ab on apache:develop.

@yuz10 yuz10 merged commit aa908ce into apache:develop Apr 15, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants