Skip to content

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Apr 3, 2022

Make sure set the target branch to develop
#4107
rocketmq-tools is the admin client module, it should not depend on rocketmq-store, which is broker storage module.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 51.839% when pulling a099a33 on yuz10:develop1 into fd554ab on apache:develop.

@coveralls
Copy link

coveralls commented Apr 3, 2022

Coverage Status

Coverage increased (+0.1%) to 52.069% when pulling 299b32f on yuz10:develop1 into fd554ab on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #4108 (a099a33) into develop (fd554ab) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4108      +/-   ##
=============================================
+ Coverage      47.91%   47.95%   +0.04%     
- Complexity      5001     5006       +5     
=============================================
  Files            634      635       +1     
  Lines          42529    42530       +1     
  Branches        5573     5573              
=============================================
+ Hits           20377    20396      +19     
+ Misses         19651    19639      -12     
+ Partials        2501     2495       -6     
Impacted Files Coverage Δ
...n/java/org/apache/rocketmq/common/stats/Stats.java 0.00% <0.00%> (ø)
...pache/rocketmq/store/stats/BrokerStatsManager.java 71.87% <ø> (ø)
...tmq/tools/command/export/ExportMetricsCommand.java 0.00% <ø> (ø)
...cketmq/tools/command/stats/StatsAllSubCommand.java 0.00% <0.00%> (ø)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.40% <0.00%> (-0.36%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.59% <0.00%> (+0.37%) ⬆️
...a/org/apache/rocketmq/store/StoreStatsService.java 37.53% <0.00%> (+0.56%) ⬆️
...n/java/org/apache/rocketmq/store/ha/HAService.java 72.33% <0.00%> (+0.66%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.18% <0.00%> (+1.48%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd554ab...a099a33. Read the comment docs.

@RongtongJin
Copy link
Contributor

LGTM~

@yuz10 yuz10 added this to the 4.9.4 milestone Apr 22, 2022
@lwclover
Copy link
Contributor

What are the rules for merging?

@RongtongJin RongtongJin merged commit 5d01023 into apache:develop Apr 25, 2022
samz406 pushed a commit to samz406/rocketmq that referenced this pull request Apr 26, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.