-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #4107] rocketmq-tools should not depend on rocketmq-store #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4108 +/- ##
=============================================
+ Coverage 47.91% 47.95% +0.04%
- Complexity 5001 5006 +5
=============================================
Files 634 635 +1
Lines 42529 42530 +1
Branches 5573 5573
=============================================
+ Hits 20377 20396 +19
+ Misses 19651 19639 -12
+ Partials 2501 2495 -6
Continue to review full report at Codecov.
|
ltamber
reviewed
Apr 6, 2022
store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java
Outdated
Show resolved
Hide resolved
HScarb
reviewed
Apr 6, 2022
store/src/main/java/org/apache/rocketmq/store/stats/BrokerStatsManager.java
Show resolved
Hide resolved
ni-ze
approved these changes
Apr 7, 2022
RongtongJin
approved these changes
Apr 7, 2022
LGTM~ |
tianliuliu
approved these changes
Apr 8, 2022
panzhi33
approved these changes
Apr 8, 2022
odbozhou
approved these changes
Apr 13, 2022
lwclover
approved these changes
Apr 24, 2022
What are the rules for merging? |
samz406
pushed a commit
to samz406/rocketmq
that referenced
this pull request
Apr 26, 2022
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
#4107
rocketmq-tools is the admin client module, it should not depend on rocketmq-store, which is broker storage module.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.