Skip to content

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Apr 6, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #3914

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #4122 (8d704bd) into develop (e7c87fa) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4122      +/-   ##
=============================================
+ Coverage      47.92%   47.98%   +0.06%     
- Complexity      4999     5010      +11     
=============================================
  Files            634      635       +1     
  Lines          42529    42514      -15     
  Branches        5573     5567       -6     
=============================================
+ Hits           20380    20401      +21     
+ Misses         19651    19624      -27     
+ Partials        2498     2489       -9     
Impacted Files Coverage Δ
...ache/rocketmq/store/config/MessageStoreConfig.java 61.72% <100.00%> (+0.47%) ⬆️
...pache/rocketmq/store/dledger/DLedgerCommitLog.java 76.17% <100.00%> (+0.19%) ⬆️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 41.05% <0.00%> (-2.99%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 50.74% <0.00%> (-1.50%) ⬇️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 57.92% <0.00%> (-0.50%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.88% <0.00%> (-0.47%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.64% <0.00%> (-0.36%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 50.83% <0.00%> (-0.31%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c87fa...8d704bd. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 51.887% when pulling 0c23af7 on cserwen:multi_dir into 8745d4c on apache:develop.

@coveralls
Copy link

coveralls commented Apr 7, 2022

Coverage Status

Coverage decreased (-0.1%) to 51.839% when pulling 8d704bd on cserwen:multi_dir into ead6274 on apache:develop.

@cserwen
Copy link
Member Author

cserwen commented Apr 7, 2022

@RongtongJin @Jason918 Hello, can you help me to review this pr?

@cserwen
Copy link
Member Author

cserwen commented Apr 12, 2022

@RongtongJin ping~

@cserwen
Copy link
Member Author

cserwen commented Apr 18, 2022

@Jason918 ping

Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left some minor question.

@RongtongJin RongtongJin merged commit 2bd9059 into apache:develop Apr 22, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RIP-7] Support multi-directory storage in DLedger.
7 participants