Skip to content

Conversation

li-xiao-shuang
Copy link
Member

fix : #4127

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #4128 (d7f3dc8) into develop (13765b0) will decrease coverage by 0.03%.
The diff coverage is 61.11%.

@@              Coverage Diff              @@
##             develop    #4128      +/-   ##
=============================================
- Coverage      47.96%   47.92%   -0.04%     
+ Complexity      5007     5003       -4     
=============================================
  Files            635      635              
  Lines          42504    42504              
  Branches        5567     5567              
=============================================
- Hits           20386    20369      -17     
- Misses         19627    19651      +24     
+ Partials        2491     2484       -7     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 46.63% <0.00%> (ø)
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 46.47% <62.85%> (ø)
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-8.96%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 41.05% <0.00%> (-2.99%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.97% <0.00%> (-0.57%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 75.19% <0.00%> (-0.52%) ⬇️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 57.92% <0.00%> (-0.50%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.88% <0.00%> (-0.47%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13765b0...d7f3dc8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 51.936% when pulling d7f3dc8 on li-xiao-shuang:feature_#4127 into 13765b0 on apache:develop.

@li-xiao-shuang li-xiao-shuang requested a review from odbozhou April 11, 2022 02:34
@RongtongJin RongtongJin merged commit 519c0b8 into apache:develop Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BrokerOuterAPI] Anonymous new Runnable() can be replaced with lambda
9 participants