Skip to content

Conversation

caigy
Copy link
Contributor

@caigy caigy commented Apr 12, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4155

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@caigy caigy changed the title [ISSUE 4155] fix system property setting causing data conflicts in acl test [ISSUE #4155] fix system property setting causing data conflicts in acl test Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #4156 (c61e48f) into develop (ead6274) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4156      +/-   ##
=============================================
- Coverage      48.06%   47.97%   -0.09%     
+ Complexity      5017     5010       -7     
=============================================
  Files            635      635              
  Lines          42506    42506              
  Branches        5567     5567              
=============================================
- Hits           20429    20393      -36     
- Misses         19593    19619      +26     
- Partials        2484     2494      +10     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-10.45%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.49%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.41% <0.00%> (-1.13%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.66% <0.00%> (-0.67%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.79% <0.00%> (-0.52%) ⬇️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.40% <0.00%> (-0.36%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (-0.16%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead6274...c61e48f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 51.988% when pulling c61e48f on caigy:fix-acl-test into ead6274 on apache:develop.

@yuz10 yuz10 merged commit 9563683 into apache:develop Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit tests in rocketmq-acl may fail due to data conflict
4 participants