Skip to content

Conversation

li-xiao-shuang
Copy link
Member

fix : #4185
Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #4186 (b8899a7) into develop (580b76d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4186      +/-   ##
=============================================
+ Coverage      48.04%   48.05%   +0.01%     
- Complexity      5020     5021       +1     
=============================================
  Files            635      635              
  Lines          42493    42495       +2     
  Branches        5567     5568       +1     
=============================================
+ Hits           20415    20423       +8     
+ Misses         19592    19583       -9     
- Partials        2486     2489       +3     
Impacted Files Coverage Δ
...rocketmq/common/protocol/route/TopicRouteData.java 39.34% <100.00%> (ø)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.79% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 50.00% <0.00%> (-0.36%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 51.13% <0.00%> (-0.16%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.31% <0.00%> (-0.11%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580b76d...b8899a7. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 52.032% when pulling b8899a7 on li-xiao-shuang:replaced-argument into d1f8124 on apache:develop.

@duhenglucky duhenglucky merged commit 4f2b708 into apache:develop Apr 21, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone Apr 21, 2022
@yuz10
Copy link
Member

yuz10 commented Apr 21, 2022

is rocketmq-common supposed to compile with jdk1.7?

GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TopicRouteData] Explicit type argument can be replaced with <>
7 participants