Skip to content

Conversation

dongeforever
Copy link
Member

@dongeforever dongeforever commented May 7, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix ISSUE #4251

Brief changelog

add two sys flag in MessageSysFlag

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 52.231% when pulling 69647cd on dongeforever:add_batch_flag into 7043211 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #4252 (69647cd) into develop (7043211) will increase coverage by 0.09%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4252      +/-   ##
=============================================
+ Coverage      48.10%   48.19%   +0.09%     
- Complexity      5073     5084      +11     
=============================================
  Files            642      642              
  Lines          42789    42789              
  Branches        5601     5601              
=============================================
+ Hits           20582    20621      +39     
+ Misses         19688    19663      -25     
+ Partials        2519     2505      -14     
Impacted Files Coverage Δ
...apache/rocketmq/common/sysflag/MessageSysFlag.java 20.00% <ø> (ø)
...ketmq/common/protocol/body/RegisterBrokerBody.java 84.78% <0.00%> (-1.09%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 75.08% <0.00%> (+0.11%) ⬆️
...ain/java/org/apache/rocketmq/store/MappedFile.java 51.40% <0.00%> (+0.35%) ⬆️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.85% <0.00%> (+0.66%) ⬆️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.83% <0.00%> (+0.83%) ⬆️
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 60.20% <0.00%> (+1.02%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 65.34% <0.00%> (+1.42%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 84.39% <0.00%> (+1.46%) ⬆️
...a/org/apache/rocketmq/store/StoreStatsService.java 37.53% <0.00%> (+1.68%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7043211...69647cd. Read the comment docs.

@duhenglucky duhenglucky merged commit c046404 into apache:develop May 7, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone May 7, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* Add it test holder for manual test

* Add it test holder for manual test

* Polish the test, remove useless code

* Polish the test, remove useless code

* Mark the flag for batch to avoid conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants