Skip to content

Conversation

MinXie1209
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

use function computeIfAbsent replace if #4254

Brief changelog

use function computeIfAbsent replace if #4254

Verifying this change

use function computeIfAbsent replace if #4254

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #4255 (db6a3e1) into develop (9f97eba) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4255      +/-   ##
=============================================
- Coverage      48.11%   48.10%   -0.01%     
- Complexity      5057     5068      +11     
=============================================
  Files            637      642       +5     
  Lines          42628    42786     +158     
  Branches        5598     5600       +2     
=============================================
+ Hits           20510    20583      +73     
- Misses         19603    19688      +85     
  Partials        2515     2515              
Impacted Files Coverage Δ
...pache/rocketmq/store/dledger/DLedgerCommitLog.java 76.07% <100.00%> (-0.15%) ⬇️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 44.77% <0.00%> (-10.45%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 85.00% <0.00%> (-5.00%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 47.08% <0.00%> (-4.02%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.83% <0.00%> (-3.34%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f97eba...db6a3e1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 52.068% when pulling db6a3e1 on MinXie1209:develop-0508 into c046404 on apache:develop.

@duhenglucky duhenglucky added this to the 4.9.4 milestone May 8, 2022
@duhenglucky duhenglucky merged commit 5d2bf35 into apache:develop May 9, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
)

* use computeIfAbsent

* [ISSUE apache#4254] use function computeIfAbsent replace if

Co-authored-by: xyj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants