Skip to content

Conversation

Oliverwqcwrw
Copy link
Member

@Oliverwqcwrw Oliverwqcwrw commented May 12, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4325

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #4279 (28c6197) into develop (5d2bf35) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4279      +/-   ##
=============================================
+ Coverage      48.17%   48.21%   +0.04%     
- Complexity      5081     5088       +7     
=============================================
  Files            642      642              
  Lines          42780    42780              
  Branches        5599     5599              
=============================================
+ Hits           20610    20628      +18     
+ Misses         19659    19643      -16     
+ Partials        2511     2509       -2     
Impacted Files Coverage Δ
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 43.83% <ø> (ø)
...org/apache/rocketmq/common/stats/StatsItemSet.java 47.76% <0.00%> (-2.99%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...rocketmq/common/message/MessageClientIDSetter.java 73.80% <0.00%> (-1.20%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.85% <0.00%> (+0.66%) ⬆️
...ketmq/common/protocol/body/RegisterBrokerBody.java 85.86% <0.00%> (+1.08%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 84.39% <0.00%> (+1.46%) ⬆️
...va/org/apache/rocketmq/common/stats/StatsItem.java 55.83% <0.00%> (+5.00%) ⬆️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 71.42% <0.00%> (+5.35%) ⬆️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 52.17% <0.00%> (+8.69%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2bf35...28c6197. Read the comment docs.

@Oliverwqcwrw Oliverwqcwrw changed the title [Polish] Remove redundant exception to improve readability [ISSUE #4325] Remove redundant exception to improve readability May 16, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit dd69223 into apache:develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant exception
6 participants