[ISSUE #4292] Add description to the community list of README file #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzh0425
reviewed
May 13, 2022
| * [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals) | ||
| * [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP. | ||
| * [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors. | ||
|
|
There was a problem hiding this comment.
Have you discussed this practice with the community?
|
@hzh0425 @terrance-swn It's a good practice to add a short description for each eco-repo, but would you like resolve the conflicts first? |
hzh0425
approved these changes
May 13, 2022
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #4296 +/- ##
=============================================
- Coverage 48.18% 48.06% -0.13%
+ Complexity 5085 5069 -16
=============================================
Files 642 642
Lines 42780 42780
Branches 5599 5599
=============================================
- Hits 20614 20561 -53
- Misses 19650 19707 +57
+ Partials 2516 2512 -4
Continue to review full report at Codecov.
|
caigy
requested changes
May 15, 2022
Comment on lines
+39
to
+40
| * [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client. | ||
| * [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client. |
There was a problem hiding this comment.
Seems not more descriptive than the original ones. Maybe you can refer to corresponding projects for more specific description.
| * [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems | ||
| * [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt) | ||
| * [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals) | ||
| * [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes. |
There was a problem hiding this comment.
- It seems
Providingshould be used instead ofProvides. an Apache RocketMQ clusteris more appropriate.
| * [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ. | ||
| * [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems. | ||
| * [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP. | ||
| * [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors. |
There was a problem hiding this comment.
- Please use
Apache RocketMQfor consistency. - Could you please explain the meaning of 'warehouse' here? It is a bit confusing.
- rocketmq-externals is a repository for incubator projects related to Apache RocketMQ, not limited to connectors.
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
[ISSUE apache#4292] Add description to the community list of README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
Add description to the community list of README file.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.