Skip to content

Conversation

hzh0425
Copy link
Member

@hzh0425 hzh0425 commented May 13, 2022

Make sure set the target branch to develop

What is the purpose of the change

Optimize ServiceProvider's code

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #4311 (2fe622c) into develop (9445b78) will decrease coverage by 0.10%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #4311      +/-   ##
=============================================
- Coverage      48.18%   48.07%   -0.11%     
+ Complexity      5085     5064      -21     
=============================================
  Files            642      642              
  Lines          42780    42774       -6     
  Branches        5599     5599              
=============================================
- Hits           20614    20565      -49     
- Misses         19650    19694      +44     
+ Partials        2516     2515       -1     
Impacted Files Coverage Δ
...g/apache/rocketmq/broker/util/ServiceProvider.java 47.43% <33.33%> (+1.00%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-13.05%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.83% <0.00%> (-5.00%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.84% <0.00%> (-3.00%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.64% <0.00%> (-0.71%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9445b78...2fe622c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 52.006% when pulling 2fe622c on hzh0425:fix/optimize_serviceProvider into 9445b78 on apache:develop.

Copy link
Member

@li-xiao-shuang li-xiao-shuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit bee73b3 into apache:develop May 14, 2022
@RongtongJin RongtongJin added this to the 4.9.4 milestone May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants