-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #2435] Solve the problem that DefaultMQProducer#request() sends messages and waits for timeout synchronously #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## develop #4313 +/- ##
=============================================
- Coverage 48.18% 48.14% -0.04%
+ Complexity 5085 5072 -13
=============================================
Files 642 642
Lines 42780 42782 +2
Branches 5599 5599
=============================================
- Hits 20614 20598 -16
- Misses 19650 19670 +20
+ Partials 2516 2514 -2
Continue to review full report at Codecov.
|
…) sends messages and waits for timeout synchronously (apache#4313) * Fix message callback timeout bug * Clean up code format * Fix message callback timeout bug Co-authored-by: Heng Du <[email protected]>
…) sends messages and waits for timeout synchronously (apache#4313) * Fix message callback timeout bug * Clean up code format * Fix message callback timeout bug Co-authored-by: Heng Du <[email protected]>
这么修改相当于在执行sendCallback的onSuccess的时候就立即执行了requestResponseFuture的putResponseMessage或者executeRequestCallback,这俩不是应该在收到replyMsg之后再执行吗,即ClientRemotingProcessor里processReplyMessage做的事情?看Issue #2435里的报错,是因为broker reply msg的时候,request请求的producer已经unregister了。 cc @duhenglucky |
fix : #2435