Skip to content

Conversation

coderbruis
Copy link
Contributor

@coderbruis coderbruis commented May 14, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix for statement does not loop

Brief changelog

fix for statement does not loop

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@li-xiao-shuang
Copy link
Member

Could you create an issue description for this problem?

@coderbruis
Copy link
Contributor Author

Could you create an issue description for this problem?

这个For循环是无效的,可以去掉。

@hzh0425
Copy link
Member

hzh0425 commented May 14, 2022

Could you create an issue description for this problem?

这个For循环是无效的,可以去掉。

Yep, 你说得对, 但是需要开一个 issue 来描述

@coderbruis coderbruis changed the title fix for statement does not loop [ISSUE #4317] Fix for statement does not loop May 14, 2022
@coderbruis
Copy link
Contributor Author

Could you create an issue description for this problem?

这个For循环是无效的,可以去掉。

Yep, 你说得对, 但是需要开一个 issue 来描述

DONE

@li-xiao-shuang
Copy link
Member

fix : #4317

@RongtongJin RongtongJin added this to the 4.9.4 milestone May 17, 2022
@RongtongJin RongtongJin merged commit 84fb5e1 into apache:develop May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants