Skip to content

Conversation

coderbruis
Copy link
Contributor

What is the purpose of the change

Remove duplicate code in Level#toLevel.

Brief changelog

Remove duplicate code in Level#toLevel.

@coderbruis coderbruis changed the title Remove duplicate code [ISSUE #4332] Remove duplicate code May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #4331 (5704c0c) into develop (7982c9c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4331   +/-   ##
==========================================
  Coverage      48.19%   48.20%           
- Complexity      5085     5087    +2     
==========================================
  Files            642      642           
  Lines          42767    42765    -2     
  Branches        5598     5597    -1     
==========================================
+ Hits           20610    20613    +3     
+ Misses         19649    19643    -6     
- Partials        2508     2509    +1     
Impacted Files Coverage Δ
.../java/org/apache/rocketmq/logging/inner/Level.java 39.58% <ø> (+1.58%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-10.72%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 43.47% <0.00%> (-4.35%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.83% <0.00%> (-4.17%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 52.23% <0.00%> (-1.50%) ⬇️
...n/java/org/apache/rocketmq/store/ha/HAService.java 70.76% <0.00%> (-1.00%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 36.97% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7982c9c...5704c0c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 52.052% when pulling 5704c0c on coderbruis:REMOVE_DUPLICATE_CODE into 7982c9c on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 52.052% when pulling 5704c0c on coderbruis:REMOVE_DUPLICATE_CODE into 7982c9c on apache:develop.

@RongtongJin RongtongJin added this to the 4.9.4 milestone May 17, 2022
@RongtongJin RongtongJin merged commit 859401f into apache:develop May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants