Skip to content

Conversation

hzh0425
Copy link
Member

@hzh0425 hzh0425 commented Jun 2, 2022

Make sure set the target branch to develop

What is the purpose of the change

Tracking issue: #4330
Fix allAckSyncStateSet not working

Brief changelog

Replace clientAddress to slaveAddress.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #4401 (2650b2a) into 5.0.0-beta-dledger-controller (99d77df) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4401      +/-   ##
===================================================================
+ Coverage                            43.31%   43.32%   +0.01%     
- Complexity                            6342     6343       +1     
===================================================================
  Files                                  839      839              
  Lines                                59640    59640              
  Branches                              8130     8130              
===================================================================
+ Hits                                 25831    25842      +11     
+ Misses                               30460    30446      -14     
- Partials                              3349     3352       +3     
Impacted Files Coverage Δ
...apache/rocketmq/store/ha/GroupTransferService.java 83.33% <0.00%> (ø)
.../org/apache/rocketmq/store/PutMessageSpinLock.java 85.71% <0.00%> (-14.29%) ⬇️
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 49.72% <0.00%> (-0.56%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (+0.31%) ⬆️
...che/rocketmq/acl/plain/PlainPermissionManager.java 75.70% <0.00%> (+0.51%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.43% <0.00%> (+0.51%) ⬆️
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 58.00% <0.00%> (+2.00%) ⬆️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 62.39% <0.00%> (+2.56%) ⬆️
...controller/impl/DefaultBrokerHeartbeatManager.java 87.67% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d77df...2650b2a. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 47.49% when pulling 2650b2a on hzh0425:fix/fix-option-allAckSyncStateSet into 99d77df on apache:5.0.0-beta-dledger-controller.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 47.49% when pulling 2650b2a on hzh0425:fix/fix-option-allAckSyncStateSet into 99d77df on apache:5.0.0-beta-dledger-controller.

@RongtongJin RongtongJin merged commit c4a7acd into apache:5.0.0-beta-dledger-controller Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants