Skip to content

Conversation

GLBB
Copy link
Contributor

@GLBB GLBB commented Jun 4, 2022

remove useless check about "properties"

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@GLBB GLBB changed the title [ISSUE #4410] Optimize method org.apache.rocketmq.common.message.MessageDecoder#messageProperties2String, remove useless check [ISSUE #4410] Optimize method org.apache.rocketmq.common.message.MessageDecoder#messageProperties2String, remove useless check Jun 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #4411 (9d9e165) into develop (0fca6df) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             develop    #4411   +/-   ##
==========================================
  Coverage      48.20%   48.20%           
+ Complexity      5092     5090    -2     
==========================================
  Files            642      642           
  Lines          42752    42751    -1     
  Branches        5591     5590    -1     
==========================================
+ Hits           20609    20610    +1     
+ Misses         19643    19632   -11     
- Partials        2500     2509    +9     
Impacted Files Coverage Δ
...apache/rocketmq/common/message/MessageDecoder.java 80.88% <75.00%> (+0.29%) ⬆️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 72.05% <0.00%> (-1.48%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 37.53% <0.00%> (-1.13%) ⬇️
...client/consumer/store/RemoteBrokerOffsetStore.java 70.27% <0.00%> (-0.91%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 43.75% <0.00%> (-0.79%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 70.84% <0.00%> (-0.68%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.43% <0.00%> (-0.49%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fca6df...9d9e165. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 52.184% when pulling 9d9e165 on GLBB:ROCKETMQ-4410 into 0fca6df on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 52.184% when pulling 9d9e165 on GLBB:ROCKETMQ-4410 into 0fca6df on apache:develop.

Copy link
Member

@hzh0425 hzh0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GLBB GLBB changed the title [ISSUE #4410] Optimize method org.apache.rocketmq.common.message.MessageDecoder#messageProperties2String, remove useless check [ISSUE #4410] Optimize method org.apache.rocketmq.common.message.MessageDecoder#messageProperties2String, remove useless check Jun 5, 2022
@duhenglucky duhenglucky merged commit 9ceff5c into apache:develop Jun 6, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone Jun 6, 2022
madongming1001 pushed a commit to madongming1001/rocketmq that referenced this pull request Jun 6, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants