[Summer of code] Use confirm offset in ReputMessageService #4449
Conversation
| if (this.defaultMessageStore.getMessageStoreConfig().getBrokerRole() == BrokerRole.SYNC_MASTER) { | ||
| final Set<String> currentSyncStateSet = getSyncStateSet(); | ||
| long confirmOffset = this.defaultMessageStore.getMaxPhyOffset(); | ||
| for (HAConnection connection : this.connectionList) { | ||
| if (currentSyncStateSet.contains(connection.getClientAddress())) { | ||
| confirmOffset = Math.min(confirmOffset, connection.getSlaveAckOffset()); | ||
| } | ||
| } | ||
| return confirmOffset; | ||
| } else { | ||
| if (this.haClient != null) { | ||
| return this.haClient.getConfirmOffset(); |
There was a problem hiding this comment.
这里可以做一个优化。。把confirmOffset记录下来，利用空间换时间，再每次slave ack的时候更新。。不然每次reput一条消息都会调用一下，比较消耗资源。
|
问题场景: 网络分区下, master 与 slave, master 与 controller 都分区了, 但是没有和 client 分区. client 继续往 master 发送消息. 虽然在 allAckSyncStateSet = true 下, 不会发送成功, 但是这些消息仍然会被 reput by reputMessageService. |
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4449 +/- ##
===================================================================
+ Coverage 43.17% 43.28% +0.10%
- Complexity 6343 6369 +26
===================================================================
Files 841 841
Lines 59824 59857 +33
Branches 8152 8161 +9
===================================================================
+ Hits 25830 25909 +79
+ Misses 30643 30594 -49
- Partials 3351 3354 +3
Continue to review full report at Codecov.
|
Make sure set the target branch to
developWhat is the purpose of the change
tracking issue: #4330
Brief changelog
Use confirm offset in ReputMessageService
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.