-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead #4467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead #4467
Conversation
Hi @Kvicii Have you reviewed this PR carefully? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
store/src/test/java/org/apache/rocketmq/store/ha/HAServerTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4467 +/- ##
===================================================================
- Coverage 43.20% 43.19% -0.01%
+ Complexity 6365 6358 -7
===================================================================
Files 841 841
Lines 59862 59861 -1
Branches 8160 8162 +2
===================================================================
- Hits 25864 25858 -6
- Misses 30650 30656 +6
+ Partials 3348 3347 -1
Continue to review full report at Codecov.
|
What is the purpose of the change
Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead
Brief changelog
Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.