Skip to content

Conversation

RongtongJin
Copy link
Contributor

What is the purpose of the change

Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead

Brief changelog

Remove allAckInSyncStateSet in GroupCommitRequest and use ackNums = -1 instead

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin
Copy link
Contributor Author

Hi @Kvicii Have you reviewed this PR carefully?

Copy link
Member

@hzh0425 hzh0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #4467 (32cd55d) into 5.0.0-beta-dledger-controller (fd804d9) will decrease coverage by 0.00%.
The diff coverage is 59.09%.

@@                         Coverage Diff                         @@
##             5.0.0-beta-dledger-controller    #4467      +/-   ##
===================================================================
- Coverage                            43.20%   43.19%   -0.01%     
+ Complexity                            6365     6358       -7     
===================================================================
  Files                                  841      841              
  Lines                                59862    59861       -1     
  Branches                              8160     8162       +2     
===================================================================
- Hits                                 25864    25858       -6     
- Misses                               30650    30656       +6     
+ Partials                              3348     3347       -1     
Impacted Files Coverage Δ
...c/main/java/org/apache/rocketmq/common/MixAll.java 44.29% <ø> (ø)
...main/java/org/apache/rocketmq/store/CommitLog.java 68.11% <50.00%> (-0.22%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <100.00%> (ø)
.../org/apache/rocketmq/store/PutMessageSpinLock.java 85.71% <0.00%> (-14.29%) ⬇️
.../broker/subscription/SubscriptionGroupManager.java 68.79% <0.00%> (-14.19%) ⬇️
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ache/rocketmq/broker/topic/TopicConfigManager.java 59.28% <0.00%> (-3.06%) ⬇️
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 59.18% <0.00%> (-1.03%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.76% <0.00%> (-0.64%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd804d9...32cd55d. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 16, 2022

Coverage Status

Coverage decreased (-0.08%) to 47.31% when pulling b2a0351 on RongtongJin:5.0.0-beta-dledger-controller-6 into fd804d9 on apache:5.0.0-beta-dledger-controller.

@ShannonDing ShannonDing merged commit 3fbcad5 into apache:5.0.0-beta-dledger-controller Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants