Skip to content

Conversation

Slideee
Copy link

@Slideee Slideee commented Sep 8, 2022

Make sure set the target branch to develop

What is the purpose of the change

#5020

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5024 (79bc3c4) into develop (f1e95cd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5024      +/-   ##
=============================================
- Coverage      43.22%   43.21%   -0.02%     
+ Complexity      7766     7760       -6     
=============================================
  Files            995      995              
  Lines          69101    69101              
  Branches        9154     9154              
=============================================
- Hits           29870    29861       -9     
- Misses         35479    35485       +6     
- Partials        3752     3755       +3     
Impacted Files Coverage Δ
...apache/rocketmq/remoting/netty/ResponseFuture.java 79.59% <0.00%> (-2.05%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-1.50%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 51.44% <0.00%> (-1.45%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 68.46% <0.00%> (-0.91%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.85% <0.00%> (-0.48%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 37.44% <0.00%> (-0.24%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.21% <0.00%> (-0.16%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Slideee
Copy link
Author

Slideee commented Sep 22, 2022

@RongtongJin Hi, can this PR be merged?

@lizhanhui lizhanhui merged commit 294e263 into apache:develop Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants