Skip to content

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Close #5100
Recover the optimization of pull request #2885

Brief changelog

Recover the optimization of pull request #2885

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5101 (55f69e0) into develop (8ba84c3) will increase coverage by 0.09%.
The diff coverage is 85.33%.

@@              Coverage Diff              @@
##             develop    #5101      +/-   ##
=============================================
+ Coverage      43.17%   43.26%   +0.09%     
- Complexity      7758     7790      +32     
=============================================
  Files            995      996       +1     
  Lines          69170    69234      +64     
  Branches        9154     9157       +3     
=============================================
+ Hits           29862    29956      +94     
+ Misses         35547    35515      -32     
- Partials        3761     3763       +2     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <66.66%> (-6.19%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <95.83%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 38.67% <0.00%> (-1.11%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.37% <0.00%> (-0.63%) ⬇️
...apache/rocketmq/store/queue/BatchConsumeQueue.java 68.25% <0.00%> (-0.63%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link #3979

@ShannonDing ShannonDing merged commit b50f55f into apache:develop Sep 19, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* Recover the optimization of pull request #2885

* Optimize the use of computeIfAbsent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recover the optimization of pull request #2885
4 participants