Skip to content

[ISSUE #5095] [Remoting-C] Support output thread exception information to the error log #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022
Merged

[ISSUE #5095] [Remoting-C] Support output thread exception information to the error log #5129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a721ddc
[ISSUE #5095] [Remoting-C] Support output thread exception informatio…
lizhimins Sep 20, 2022
d3e832b
[ISSUE #5095] [Remoting-C] Support output thread exception informatio…
lizhimins Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions common/src/main/java/org/apache/rocketmq/common/ThreadFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@

import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicLong;
import org.apache.rocketmq.common.constant.LoggerName;
import org.apache.rocketmq.logging.InternalLogger;
import org.apache.rocketmq.logging.InternalLoggerFactory;

public class ThreadFactoryImpl implements ThreadFactory {

private static final InternalLogger LOGGER = InternalLoggerFactory.getLogger(LoggerName.COMMON_LOGGER_NAME);

private final AtomicLong threadIndex = new AtomicLong(0);
private final String threadNamePrefix;
private final boolean daemon;
Expand Down Expand Up @@ -51,6 +57,12 @@ public ThreadFactoryImpl(final String threadNamePrefix, boolean daemon, BrokerId
public Thread newThread(Runnable r) {
Thread thread = new Thread(r, threadNamePrefix + this.threadIndex.incrementAndGet());
thread.setDaemon(daemon);

// Log all uncaught exception
thread.setUncaughtExceptionHandler((t, e) ->
LOGGER.error("[BUG] Thread has an uncaught exception, threadId={}, threadName={}",
t.getId(), t.getName(), e));

return thread;
}
}