[ISSUE #5122] Enable checkstyle for test code (rocketmq-broker module) #5193
Conversation
broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #5193 +/- ##
=============================================
+ Coverage 43.19% 43.27% +0.07%
- Complexity 7795 7813 +18
=============================================
Files 998 998
Lines 69456 69456
Branches 9174 9174
=============================================
+ Hits 30002 30054 +52
+ Misses 35671 35629 -42
+ Partials 3783 3773 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@nowinkeyy Could you rebase to the latest develop branch and force-push to your remote branch? It seems that irrelevant test don't pass. |
|
Hi @lizhanhui. I'm sorry i hit the wrong button, and now it seems to need your review. |
There was a problem hiding this comment.
Hi @nowinkeyy ,
Great improvement. However, I'm a bit confused with some changes in your PR.
.asf.yaml
Outdated
| @@ -27,7 +27,7 @@ github: | |||
| # Enable squash button | |||
| squash: true | |||
| # Disable merge button | |||
| merge: true | |||
| merge: false | |||
There was a problem hiding this comment.
What is the purpose of modifying this parameter?
There was a problem hiding this comment.
Looks some commits from develop branch are merged.
There was a problem hiding this comment.
yeah, this submission is the result of rebase the develop branch.
README.md
Outdated
| [](http://isitmaintained.com/project/apache/rocketmq "Percentage of issues still open") | ||
| [](https://twitter.com/intent/follow?screen_name=ApacheRocketMQ) | ||
| ## Apache RocketMQ | ||
|
|
There was a problem hiding this comment.
Is the change relevant to the main purpose of this PR?
There was a problem hiding this comment.
Should have been corrected.
lizhanhui
force-pushed
the
rocketmq-5122-broker
branch
from
4a2374a to
0d34a10
Compare
It's OK. Let me help you fix the CI issue. |
#5193) * style(pom):Enable checkstyle for test code * style(broker):Enable checkstyle for test code * Update pom.xml * Enable checkstyle for tests of broker module * Remove delete tmp file assertion as OS may have cron job to clean them * Fix bazel issue Co-authored-by: Aaron Ai <[email protected]> Co-authored-by: Li Zhanhui <[email protected]>
Make sure set the target branch to
developWhat is the purpose of the change
The first PR #5166
fix #5122 for rocketmq-broker module
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.