[ISSUE #5214] compatible rocketmq-mqtt save offset #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, it's better to create an issue first. |
ShannonDing
changed the title
ShannonDing
requested review from
Erik1288,
RongtongJin,
pingww and
tianliuliu
odbozhou
approved these changes
Sep 29, 2022
drpmma
pushed a commit
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
close #5200
In RocketMQ 4.9.3，the interface updateConsumerOffset does not check whether the topic exists or not. But in RocketMQ 5.0 do the check. LMQ's topic will not register to namesv， so it will throw error when save offset in rocketmq-mqtt.
apache/rocketmq-mqtt#150
Brief changelog
add containsTopic interface in TopicConfigManager, when enable lmq it will use LmqTopicConfigManager#containsTopic which process LMQ Topic