-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #5231] Optimize reput message code. #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5229 +/- ##
=============================================
- Coverage 43.21% 43.17% -0.04%
- Complexity 7803 7804 +1
=============================================
Files 998 998
Lines 69460 69459 -1
Branches 9177 9174 -3
=============================================
- Hits 30016 29992 -24
- Misses 35666 35703 +37
+ Partials 3778 3764 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey you need any help to solve ? |
Hi @echooymxq, the code is ok, could you create an issue related to the pull request? |
Ok, close #5231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~~
Make sure set the target branch to
develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.