Skip to content

Conversation

echooymxq
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5229 (f8fb0ea) into develop (a5725c6) will decrease coverage by 0.03%.
The diff coverage is 55.81%.

@@              Coverage Diff              @@
##             develop    #5229      +/-   ##
=============================================
- Coverage      43.21%   43.17%   -0.04%     
- Complexity      7803     7804       +1     
=============================================
  Files            998      998              
  Lines          69460    69459       -1     
  Branches        9177     9174       -3     
=============================================
- Hits           30016    29992      -24     
- Misses         35666    35703      +37     
+ Partials        3778     3764      -14     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/DefaultMessageStore.java 53.50% <55.81%> (-0.07%) ⬇️
...e/rocketmq/broker/topic/LmqTopicConfigManager.java 38.46% <0.00%> (-11.54%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (-4.70%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 77.55% <0.00%> (-4.09%) ⬇️
...mq/broker/topic/TopicQueueMappingCleanService.java 12.43% <0.00%> (-3.63%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 49.27% <0.00%> (-3.63%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...etmq/broker/processor/ConsumerManageProcessor.java 9.25% <0.00%> (-0.56%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.60% <0.00%> (-0.32%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rocketchat23
Copy link

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.

  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.

  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.

  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Hey you need any help to solve ?

@RongtongJin
Copy link
Contributor

Hi @echooymxq, the code is ok, could you create an issue related to the pull request?

@echooymxq
Copy link
Contributor Author

echooymxq commented Sep 29, 2022

Hi @echooymxq, the code is ok, could you create an issue related to the pull request?

Ok, close #5231

@RongtongJin RongtongJin changed the title Optimize reput message code. [ISSUE #5231] Optimize reput message code. Sep 29, 2022
Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

@RongtongJin RongtongJin merged commit 099418f into apache:develop Sep 30, 2022
@echooymxq echooymxq deleted the optimize branch October 12, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants