Skip to content

Conversation

lizhanhui
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Fix #5276

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5280 (e035eac) into develop (d631670) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #5280   +/-   ##
==========================================
  Coverage      43.19%   43.19%           
- Complexity      7808     7810    +2     
==========================================
  Files            998      998           
  Lines          69453    69453           
  Branches        9170     9170           
==========================================
+ Hits           29998    30000    +2     
  Misses         35683    35683           
+ Partials        3772     3770    -2     
Impacted Files Coverage Δ
...tools/command/namesrv/WipeWritePermSubCommand.java 69.23% <0.00%> (-3.85%) ⬇️
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 56.04% <0.00%> (-3.30%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
...ava/org/apache/rocketmq/store/index/IndexFile.java 73.68% <0.00%> (-0.88%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.21% <0.00%> (-0.79%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.18% <0.00%> (+0.09%) ⬆️
...q/controller/impl/manager/ReplicasInfoManager.java 62.59% <0.00%> (+0.38%) ⬆️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 62.38% <0.00%> (+0.45%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit d8c2930 into apache:develop Oct 12, 2022
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* Use OS pick-up port

* Replace deprecated PosixParser with DefaultParser for cli argument parsing

* DefaultParser cannot parse values that contain '=' character

* Revert changes to ServerUtil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddWritePermSubCommandTest uses fixed port that may not be available
3 participants