Skip to content

Conversation

socutes
Copy link
Contributor

@socutes socutes commented Feb 18, 2023

close #6108

@socutes socutes changed the title Optimize command line tools QueryMsgByKey& QueryMsgTraceById [ISSUE #6108] Optimize command line tools QueryMsgByKey& QueryMsgTraceById Feb 18, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @socutes CI fails and you can import codestyle into your idea. reference: https://rocketmq.apache.org/docs/contributionGuide/02code-guidelines

@socutes
Copy link
Contributor Author

socutes commented Feb 19, 2023

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #6115 (c5432ac) into develop (7cfffe7) will decrease coverage by 0.02%.
The diff coverage is 35.00%.

@@              Coverage Diff              @@
##             develop    #6115      +/-   ##
=============================================
- Coverage      43.18%   43.17%   -0.02%     
+ Complexity      8852     8847       -5     
=============================================
  Files           1094     1094              
  Lines          77153    77189      +36     
  Branches       10063    10069       +6     
=============================================
+ Hits           33321    33325       +4     
- Misses         39665    39690      +25     
- Partials        4167     4174       +7     
Impacted Files Coverage Δ
...tools/command/message/QueryMsgByKeySubCommand.java 0.00% <0.00%> (ø)
...s/command/message/QueryMsgTraceByIdSubCommand.java 48.83% <70.00%> (+4.71%) ⬆️
.../apache/rocketmq/store/ha/io/AbstractHAReader.java 79.31% <0.00%> (-10.35%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 74.00% <0.00%> (-2.17%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (-0.56%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 63.25% <0.00%> (-0.33%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socutes
Copy link
Contributor Author

socutes commented Feb 19, 2023

@zhouxinyu PTAL

drpmma
drpmma previously approved these changes Feb 20, 2023
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@echooymxq echooymxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks your contributions, you should also update the operation.md docs.

opt.setRequired(false);
options.addOption(opt);

opt = new Option("num", "maxNum", true, "The maximum number of messages returned by the query, default:64");
Copy link
Contributor

@echooymxq echooymxq Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change the option name to c(messageNumber), like the ConsumeMessageCommand. Simple unified use of single letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this before, and I didn't think of the right shorthand, so I used num.
Your suggestion is very good. I'll revise it.

@echooymxq
Copy link
Contributor

#5772, Maybe this Pr will close.

@socutes
Copy link
Contributor Author

socutes commented Feb 20, 2023

#5772, Maybe this Pr will close.

hi, I didn't notice this closed issue. This problem has not been fundamentally solved. The main branch does not have this function.
I think this problem is worth solving.

Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@zhouxinyu zhouxinyu merged commit 473e23b into apache:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line tool QueryMsgByKey& QueryMsgTraceById:time range and number of data bars can be specified
7 participants