Skip to content

Conversation

lyx2000
Copy link
Contributor

@lyx2000 lyx2000 commented Mar 9, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6294

Brief changelog

add GET_CONSUMER_CONNECTION_LIST to proxy

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 43.13%. Comparing base (9e0fb1b) to head (89f241c).
Report is 843 commits behind head on develop.

Files with missing lines Patch % Lines
...oxy/remoting/activity/ConsumerManagerActivity.java 0.00% 28 Missing ⚠️
...ocketmq/proxy/remoting/RemotingProtocolServer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6296      +/-   ##
=============================================
+ Coverage      43.12%   43.13%   +0.01%     
- Complexity      8847     8854       +7     
=============================================
  Files           1095     1094       -1     
  Lines          77279    77278       -1     
  Branches       10082    10084       +2     
=============================================
+ Hits           33324    33337      +13     
+ Misses         39782    39769      -13     
+ Partials        4173     4172       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouxinyu zhouxinyu merged commit e599187 into apache:develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enriching proxy functions: add GET_CONSUMER_CONNECTION_LIST request to proxy
4 participants