Skip to content

Conversation

Star-tears
Copy link
Contributor

@Star-tears Star-tears commented Mar 9, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6308

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Star-tears Thanks for your contribution, you can create issue first and then link this pr to it

Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Star-tears , thanks for improving our documentation, would you mind also fixing this at: https://github.com/apache/rocketmq-site/tree/new-official-website ? It is where our official documentation at now.

@Star-tears Star-tears changed the title fix docs [ISSUE #6292]fix docs Mar 10, 2023
@Star-tears Star-tears changed the title [ISSUE #6292]fix docs [ISSUE #6308]fix docs Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.19%. Comparing base (244e8f9) to head (49c784f).
Report is 716 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6301      +/-   ##
=============================================
+ Coverage      43.12%   43.19%   +0.06%     
- Complexity      8858     8865       +7     
=============================================
  Files           1094     1094              
  Lines          77254    77254              
  Branches       10083    10083              
=============================================
+ Hits           33319    33370      +51     
+ Misses         39761    39719      -42     
+ Partials        4174     4165       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oliverwqcwrw Oliverwqcwrw merged commit d0df051 into apache:develop Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix docs
6 participants