Skip to content

Conversation

socutes
Copy link
Contributor

@socutes socutes commented Mar 11, 2023

close #6313

@codecov-commenter
Copy link

Codecov Report

Merging #6314 (6be1e7c) into develop (d0df051) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6314   +/-   ##
==========================================
  Coverage      43.11%   43.12%           
- Complexity      8853     8858    +5     
==========================================
  Files           1094     1094           
  Lines          77284    77284           
  Branches       10085    10085           
==========================================
+ Hits           33321    33325    +4     
+ Misses         39799    39791    -8     
- Partials        4164     4168    +4     

see 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socutes
Copy link
Contributor Author

socutes commented Mar 13, 2023

@drpmma @Oliverwqcwrw PTAL

@Oliverwqcwrw
Copy link
Member

Although 31.0.1 is marked with @beta, but their (31.0.1 and 31.1) implementation is the same, is it necessary to upgrade the version?
Please let me know if i am missing something

@socutes
Copy link
Contributor Author

socutes commented Mar 14, 2023

Although 31.0.1 is marked with @beta, but their (31.0.1 and 31.1) implementation is the same, is it necessary to upgrade the version? Please let me know if i am missing something

From the point of view of the upgrade, this feature was beta in 31.0 and dropped the Beta label in 31.1.

@drpmma
Copy link
Contributor

drpmma commented Mar 15, 2023

LGTM

@drpmma drpmma merged commit 7485d3c into apache:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.google.guava version upgraded
6 participants